Repository navigation
Document comment-only edits under versioned fingerprints (workflow#1227) - #576
Merged
Merged
Conversation
From the release with durable-workflow/workflow#1239 (#1227), runs record token fingerprints that ignore comments and whitespace, so comment-only edits to workflow classes and await() conditions keep replay. Runs started earlier keep raw-line fingerprints and still treat such edits as definition changes. Adds the note to the workflow constraints page in every locale. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Review of durable-workflow/workflow#1239 made version 2 opt-in: new runs record raw-line fingerprints by default, and DW_DEFINITION_FINGERPRINT_VERSION=v2 switches once every worker is on 2.34 or later. Updated in all locales. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Docs for durable-workflow/workflow#1239, which fixes durable-workflow/workflow#1227.
Adds Comment and formatting edits (
#comment-only-edits) to the workflow constraints (determinism) page:await()conditions count as definition changes for in-flight runs.DW_DEFINITION_FINGERPRINT_VERSION=v2once all workers are upgraded. New runs then recordsha256-tokens:fingerprints, which those edits don't change.v1is safe.The section is in all seven locales, and their
source-hashes.jsonentries are updated.check-doc-translations.jspasses, andcheckTranslationUpdatespasses for the changed guide.Merge timing: merge only when the workflow release that contains #1239 ships. The text says 2.34, the expected next minor version. Correct the number in all eight files if the release ships under another version.
🤖 Generated with Claude Code